-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various D8 updates #496
Merged
Merged
Various D8 updates #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totten
force-pushed
the
master-d8-2020
branch
4 times, most recently
from
January 16, 2020 03:50
b38656d
to
988a87e
Compare
The `civicrm_webtest` module isn't workable on D8.
This build type is useful for reproducing the RoundEarth structure. However, it has the same limit that it can only load stable releases. Consequeuntly, the `--civi-ver` option will be required.
…re" instead of 'drush make'
…rom totten/5.21-packages This includes additional fixes for supporting the alternate 'packages', running 'GenCode', etc
…sset-plugin will do that.
The D7 install routine sets the file_private_path via drush. However, this was skipped in the first pass at `drupal8_install()`... probably b/c D8 doesn't allow this. D8 requires editing the `settings.php`. We achieve the same end by injecting code into D8's `settings.php`.
This was enabled in `drupal-{clean,demo,case}`, so do the same.
totten
force-pushed
the
master-d8-2020
branch
from
January 28, 2020 02:45
4b4ec2e
to
f295b70
Compare
Filled in a description; removed "WIP" label; merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a set of several Drupal 8-based build-types:
d8prj-empty
d8prj-clean
d8prj-re
drupal8-empty
drupal8-clean
Each build-type creates the admin and demo users and assigns sufficient permissions to login and navigate to the CiviCRM dashboard.
I've also had some success in getting tests to run:
Specific tests do raise issues, but the test suites on the whole are running.
See also: civicrm/civicrm-core#16328 (comment)