Setup UI - Restore icons (FontAwesome 6 support)

[totten]

Overview

Fix missing icons when installing on Backdrop 5.77+.

Follow-up to 5.77.alpha's civicrm/civicrm-core#30779 (cc @ufundo @herbdool)

Before

No pencil icon. Instead, HTTP error.

After

Icon works

Comments

The fix is for 5.77-rc. We'll need to make sure to merge-forward to master.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@totten why is it .min here https://github.com/civicrm/civicrm-core/pull/30779/files#diff-e1c52d276354eef24612a149707c8d456409bc73941bd4153e04762e90505c4bR192 but not in this PR?

[totten]

Thanks, good catch @eileenmcnaughton. I guess it probably should have the .min.

I arbitrarily copy-pasted one of the existing references from civicrm-core.git, but they appear to be mixed:

CRM/Core/Resources/Common.php:      "bower_components/font-awesome/css/all.min.css",
js/jquery/jquery.crmIconPicker.js:        $.get(CRM.config.resourceBase + 'bower_components/font-awesome/css/all.css').done(function(data) {
templates/CRM/common/fatal.tpl:    @import url({$config->resourceBase}bower_components/font-awesome/css/font-awesome.min.css);
tools/standalone/router.php:      'font-awesome.css' => $coreUrl . '/bower_components/font-awesome/css/all.min.css',

So crmIconPicker grabs all.css, but the regular web UI and the standalone-installer both use all.min.css.

[ufundo]

I think it makes sense icon picker grabs the unminified for safer/saner regexing (it's looking for classes in the css file to present as options), but everywhere else should be .min