This repository was archived by the owner on Feb 25, 2021. It is now read-only.
Import GTK in a backward compatible way #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
city41
suggested changes
Oct 29, 2018
|
Thanks @landmaj! |
|
I removed by accident Bumped version to 2.1.0, as you asked. Also updated README to reflect the changes, but I kept notice about not addressing GTK2 issues. |
|
Tested on Ubuntu Mate 18.04 and 16.04, works without issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #11 without breaking backward compatibility for older versions of MATE. The program will check MATE version and import appropriate GTK. Why is this important? Ubuntu Mate 16.04 is supported until 2021 and that version still requires older version of GTK. A lot of people are stuck at that version (including me) for example at work.
I took the liberty of fixing
setup.pya little bit, since I had to add a new file there anyway. It used tabs instead of spaces (which are used in all other files - mixed indentation is not allowed in Python 3), there were unnecessary semicolons. I also changed maintainer to author (it makes more sense in your case) and bumped version to 2.0.1.