-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing scope in habtm.rb #207
Conversation
Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
@serprex Do you have an idea why tests are failing? It looks like there is Hash passed as attribute instead of the options?
|
Yes. I'm not sure what's wrong Looks like you found it tho |
I think I've figured that out here: b93088f |
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 14 14
Lines 722 722
=======================================
Hits 597 597
Misses 125 125
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Tests are green now :) |
Great. Can merge once you agree to CLA. Seemed like previous commits knew you'd agreed but now the ci action is acting up |
Could you try posting |
@microsoft-github-policy-service agree |
Would you be willing to release this as a new version please so that I don't have to pull gem from master branch? Thank you |
Fixes #206