Include test cases for joins

[jainharsheet77]

No description provided.

[serprex]

Could you provide context on what these tests are covering which was previously not covered?

[jainharsheet77]

[Appears to be a BUG] I encountered an issue wherein tenant clause does not get appended to the query generated for joins. It happens in case of query being run inside MultiTenant.wihout and for models which have associations with an extra where condition. Happening in Rails 6.1

MultiTenant.without do
  Comment.joins(:task)
end

This should produce query with tenant scoped in it.

Produces:-
SELECT "comments".* FROM "comments" INNER JOIN "tasks" ON "tasks"."id" = "comments"."commentable_id" AND "comments"."commentable_type" = 'Task'

Should produce:-
SELECT "comments".* FROM "comments" INNER JOIN "tasks" ON "tasks"."id" = "comments"."commentable_id" AND "comments"."commentable_type" = 'Task' AND "comments"."account_id" = "tasks"."account_id"

Whereas this tenant clause is present in case of other models.

[serprex]

I'm going to need some help understanding this

This is without:

activerecord-multi-tenant/lib/activerecord-multi-tenant/multi_tenant.rb

Lines 101 to 110 in 1c1def9

	def self.without(&block)
	return block.call if self.current_tenant.nil?
	old_tenant = self.current_tenant
	begin
	self.current_tenant = nil
	return block.call
	ensure
	self.current_tenant = old_tenant
	end
	end

Are these non-multitenant associations which are failing to generate a condition? If this is an existing bug, why are the tests in this PR passing?

[jainharsheet77]

These are multi_tenant associations present in gem's schema.rb here

In case of the schema provided in the gem. For Comment model when joined with Task. The query should have
"comments"."account_id" = "tasks"."account_id" condition which it does not have.

Are the tests passing for the PR in case of rails_6_1 too. Cause it is failing in the docker setup in my local.

[serprex]

I'm confused because GitHub Actions doesn't seem to be running CI on this PR for some reason

[jainharsheet77]

Tests are failing for rails_6_1 and above

[serprex]

In CI it's only failing for 5.2, & in that case the SQL looks right only it's relying on join condition

(realizing now that this may be because your latest commit fixes the issue)

[jainharsheet77]

In case of 5.2 the test is failing because when tenant is set in scope, the query generated has both tenant scoping condition
table_a.tenant_id = <val> AND table_b.tenant_id = <val> AND table_a.tenant_id = table_b.tenant_id. But in other versions of active_records, the condition is table_a.tenant = <val> AND table_b.tenant = <val> and table_a.tenant_id = table_b.tenant_id is absent.

Should push a fix soon.

[mintuhouse]

@serprex Issue happens only on older versions of rails 5.2 i.e., 5.2.3 (It is green on latest 5.2.8)
Can drop the 5.2.3 support and say we support latest patch of minor version 5.2 like we do for 6.0, 6.1, 7.0?

[serprex]

I'm fine with removing 5.2.3 from CI