fix: inconsistent txFirstSpend #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Parsing integrity comparison: https://gist.github.com/maltemoeser/fa67ab38647cf3df5285e56a666889c1 |
Fixes a rare situation where, due to the parallel processing of transactions, it can happen that an input script is serialized as a wrapped script in a later transaction before it is serialized as a normal input script in a previous transaction. This is a simpler fix than moving the input processing of wrapped scripts to the last stage of the processing pipeline. Reparsing the chain is recommended.
fc437f9 to
9f860d6
Compare
|
Rebased on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a rare situation where, due to the parallel processing of transactions, it can happen that an input script is serialized as a wrapped script in a later transaction before it is serialized as a normal input script in a previous transaction. This is a simpler fix than moving the input processing of wrapped scripts to the last stage of the processing pipeline.
I'll double-check this with the new integrity check tool one more time before merging.
(shouldn't have #383, but made it easier for now to create the PR)