Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vjp/tree checkable #104

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Vjp/tree checkable #104

merged 2 commits into from
Nov 7, 2019

Conversation

vanceism7
Copy link
Contributor

What does this pull request do?

Adds ability to hide the checkboxes for any item not meeting user specified criteria.

Vance Palacio added 2 commits November 6, 2019 14:56
Give user the ability to hide the checkbox
ed29d83
Bump next minor version.
9fbe90f 
This is because the new feature adds an input on the tree view, which is a
breaking change
citizengabe
citizengabe approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@citizengabe citizengabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vanceism7
Copy link
Contributor Author

Thank you sir!

@vanceism7 vanceism7 merged commit c252050 into master Nov 7, 2019
@vanceism7 vanceism7 deleted the vjp/tree-checkable branch November 7, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizengabe citizengabe citizengabe approved these changes

@davezuch davezuch Awaiting requested review from davezuch

@joneshf-cn joneshf-cn Awaiting requested review from joneshf-cn

@boygao1992 boygao1992 Awaiting requested review from boygao1992

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanceism7 @citizengabe