Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add change_case() and remove_punctuation() augmentations #49

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Add change_case() and remove_punctuation() augmentations #49

merged 2 commits into from
Nov 15, 2023

Conversation

kennysong
Copy link
Contributor

Implements langcheck.augment.change_case() and langcheck.augment.remove_punctuation().

@kennysong kennysong changed the base branch from main to augment November 13, 2023 08:11
@kennysong kennysong marked this pull request as ready for review November 13, 2023 08:15
Alnusjaponica
Alnusjaponica reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@Alnusjaponica Alnusjaponica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments on implementation. Please take a look.

src/langcheck/augment/en/_change_case.py Show resolved Hide resolved
src/langcheck/augment/en/_remove_punctuation.py Show resolved Hide resolved
Base automatically changed from augment to main November 15, 2023 01:36
Alnusjaponica
Alnusjaponica approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@Alnusjaponica Alnusjaponica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the investigation. LGTM.

@kennysong
Copy link
Contributor Author

Thanks for the review Shinichi!

@kennysong kennysong merged commit 45fe908 into main Nov 15, 2023
2 checks passed
@kennysong kennysong deleted the more-augmentations branch November 15, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alnusjaponica Alnusjaponica Alnusjaponica approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kennysong @Alnusjaponica