Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.8 support #163

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Drop Python 3.8 support #163

merged 5 commits into from
Oct 28, 2024

Conversation

liwii
Copy link
Contributor

@liwii liwii commented Oct 28, 2024 •
edited
Loading

Now Python 3.8 is officially eol, it is okay for us to drop the support.

  • Updated the python versions in pyproject.toml, tests, docs... etc
  • Cleaned up deprecated type aliasess

@liwii liwii requested a review from yosukehigashi October 28, 2024 08:18
@liwii liwii marked this pull request as ready for review October 28, 2024 08:49
yosukehigashi
yosukehigashi approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@yosukehigashi yosukehigashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!🎉

@taniokay
Copy link
Contributor

taniokay commented Oct 28, 2024 •
edited
Loading

@liwii
In my latest PR #162 I temporarily pinned transformers version as < 4.46.0 because it was causing errors for Python <= 3.8, so can you also remove it from pyproject.toml?

@liwii
Copy link
Contributor Author

liwii commented Oct 28, 2024

Oh sure, thanks for letting me know!!

@liwii liwii merged commit 4be82f5 into main Oct 28, 2024
32 checks passed
@liwii liwii deleted the drop-38 branch October 28, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosukehigashi yosukehigashi yosukehigashi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liwii @taniokay @yosukehigashi