Many small edits; Comments, typos, and data validation #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Main with 2.0 release
Pull 2.1.0 release changes into main branch
abkarcher
approved these changes
Jun 28, 2024
bfussell
approved these changes
Jun 28, 2024
malbert1
approved these changes
Jun 28, 2024
|
Merged. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many fixes/cleanup to comments, extra CRLFs, and some to data output
I have addressed several data validation issues where libacvp differed from ACVP protocol min/max values. I've altered max values for some buffers/arrays (e.g. filename max length to better accommodate windows long filenames) and increased some fields marked "arbitrary" where they length proved insufficient in some cases.
I have been compiling libacvp on a wide variety of systems, include small/embedded/IOT, and along the way I've made minor fixes to address compiler warnings and hardware/compiler "quirks". One operational environment failed Hash/Shake MCT testing, and it is due to a compiler's misinterpretation of the Rightmost Outer Bits (ROB) calculation. I've change it to be explicit and avoid "pointer math".
I'm happy to change/amend as needed. I have more "feature" oriented changes in future pull requests.