Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in workflow manager modules #214

Conversation

madhansansel
Copy link
Contributor

@madhansansel madhansansel commented Dec 10, 2024

Description

Bug fixes in workflow manager modules.
- Added sample playbook for Device Configs Backup Module
- Changes in dnac.py file
- Bug fixes in accesspoint_workflow_manager module
- Enhancements in device_configs_backup_workflow_manager module to support unzipped backup file after download
- Changes in inventory_workflow_manager module
- Changes in ise_radius_integration_workflow_manager
- Changes in network_compliance_workflow_manager
- Changes in network_settings_workflow_manager
- Bug fixes in sda_fabric_devices_workflow_manager
- Bug fixes in sda_fabric_transits_workflow_manager
- Enhancements in sda_host_port_onboarding_workflow_manager module
- Changes in swim_workflow_manager module
- sda_fabric_devices_workflow_manager - attribute 'delete_fabric_device' was removed
- sda_host_port_onboarding_workflow_manager - attributes 'port_channel_details', 'port_assignment_details' were removed and attributes 'port_channels', 'fabric_site_name_hierarchy', 'port_assignments', 'wireless_ssids' were added
- device_configs_backup_workflow_managerr - attribute 'unzip_backup' was added

Type of Change

  • [ Yes] Bug fix
  • [ Yes] New feature
  • [ Yes] Breaking change
  • [ Yes] Documentation update

Checklist

  • [ Yes] My code follows the style guidelines of this project
  • [ Yes] I have performed a self-review of my own code
  • [ Yes] I have commented my code, particularly in hard-to-understand areas
  • [Yes ] I have made corresponding changes to the documentation
  • [ Yes] My changes generate no new warnings
  • [Yes ] I have added tests that prove my fix is effective or that my feature works
  • [ Yes] New and existing unit tests pass locally with my changes
  • [Yes ] Any dependent changes have been merged and published in downstream modules
  • [ Yes] All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • Tasks are idempotent (can be run multiple times without changing state)
  • Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • Playbooks are modular and reusable
  • Handlers are used for actions that need to run on change

Documentation

  • All options and parameters are documented clearly.
  • Examples are provided and tested.
  • Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

Kandarimegha and others added 30 commits November 20, 2024 16:50
…enerated password printed in terminal to device configs backup module
@madhansansel
Copy link
Contributor Author

@jbogarin and @JosePabloOcampo1212 can you please review and approve the changes?

@JosePabloOcampo1212 JosePabloOcampo1212 merged commit ff511c5 into cisco-en-programmability:develop Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants