Merge pull request #232 from cisco-en-programmability/develop

Develop
cisco-en-programmability · Feb 5, 2025 · 469d498 · 469d498
2 parents 74ccf76 + 48bccf8
commit 469d498
Show file tree

Hide file tree

Showing 23 changed files with 1,405 additions and 744 deletions.
diff --git a/README.md b/README.md
@@ -21,7 +21,7 @@ The following table shows the supported versions.
 | 2.3.5.3                  | 6.13.3                       |  2.6.11                       |
 | 2.3.7.6                  | 6.24.0                       |  2.7.4                        |
 | 2.3.7.6                  | 6.25.0                       |  2.7.5                        |
-| 2.3.7.9                  | ^6.27.0                      |  ^2.8.0                       |
+| 2.3.7.9                  | ^6.29.0                      |  ^2.8.0                       |
 
 If your Ansible collection is older please consider updating it first.
 

diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml
@@ -1420,3 +1420,22 @@ releases:
       minor_changes:
         - Fixed issues in module sda_anycast_gateways_v1
         - Fixed issues in module sda_layer3_virtual_networks_v1
+
+  6.29.0:
+    release_date: "2025-02-05"
+    changes:
+      release_summary: Changes in workflow manager modules
+      minor_changes:
+        - Changes in device_credential_workflow_manager module
+        - Changes in inventory_workflow_manager module
+        - Changes in ise_radius_integration_workflow_manager module
+        - Changes in network_settings_workflow_manager module
+        - Enhancements in provision_workflow_manager module
+        - Bug fixes in sda_fabric_devices_workflow_manager
+        - Bug fixes in sda_fabric_transits_workflow_manager
+        - Bug fixes in sda_fabric_transits_workflow_manager module
+        - Bug fixes in site_workflow_manager module
+        - Bug fixes in swim_workflow_manager module
+        - Bug fixes in template_workflow_manager module
+        - Bug fixes in user_role_workflow_manager module
+        - sda_fabric_devices_workflow_manager - attribute 'route_distribution_protocol' was removed
diff --git a/galaxy.yml b/galaxy.yml
@@ -1,7 +1,7 @@
 ---
 namespace: cisco
 name: dnac
-version: 6.28.0
+version: 6.29.0
 readme: README.md
 authors:
   - Rafael Campos <rcampos@altus.cr>

diff --git a/plugins/module_utils/dnac.py b/plugins/module_utils/dnac.py
@@ -2182,13 +2182,17 @@ def dnac_compare_equality(current_value, requested_value):
     # print("dnac_compare_equality", current_value, requested_value)
     if requested_value is None:
         return True
+
     if current_value is None:
         return True
+
     if isinstance(current_value, str) and isinstance(requested_value, str):
         if ":" in current_value and ":" in requested_value:  # Possible IPv6 addresses
             current_value = normalize_ipv6_address(current_value)
             requested_value = normalize_ipv6_address(requested_value)
+
         return current_value == requested_value
+
     if isinstance(current_value, dict) and isinstance(requested_value, dict):
         all_dict_params = list(current_value.keys()) + list(requested_value.keys())
         return not any((not fn_comp_key(param, current_value, requested_value) for param in all_dict_params))

diff --git a/plugins/modules/device_credential_workflow_manager.py b/plugins/modules/device_credential_workflow_manager.py
diff --git a/plugins/modules/inventory_workflow_manager.py b/plugins/modules/inventory_workflow_manager.py
diff --git a/plugins/modules/ise_radius_integration_workflow_manager.py b/plugins/modules/ise_radius_integration_workflow_manager.py
@@ -376,10 +376,10 @@
   sample: >
     {
       "response": {
-        "taskId": "string",
-        "url": "string"
+        "taskId": "str",
+        "url": "str"
       },
-      "version": "string"
+      "version": "str"
     }
 
 # Case_2: Successful updation of Authentication and Policy Server.
@@ -390,10 +390,10 @@
   sample: >
     {
       "response": {
-        "taskId": "string",
-        "url": "string"
+        "taskId": "str",
+        "url": "str"
       },
-      "version": "string"
+      "version": "str"
     }
 
 # Case_3: Successful creation/updation of network
@@ -404,10 +404,10 @@
   sample: >
     {
       "response": {
-        "taskId": "string",
-        "url": "string"
+        "taskId": "str",
+        "url": "str"
       },
-      "version": "string"
+      "version": "str"
     }
 """
 
@@ -459,39 +459,39 @@ def validate_input(self):
             "authentication_policy_server": {
                 "type": "list",
                 "elements": "dict",
-                "server_type": {"type": 'string', "choices": ["AAA", "ISE"]},
-                "server_ip_address": {"type": 'string'},
-                "shared_secret": {"type": 'string'},
-                "protocol": {"type": 'string', "choices": ["TACACS", "RADIUS", "RADIUS_TACACS"]},
-                "encryption_scheme": {"type": 'string'},
-                "message_authenticator_code_key": {"type": 'string'},
-                "encryption_key": {"type": 'string'},
-                "authentication_port": {"type": 'integer'},
-                "accounting_port": {"type": 'integer'},
-                "retries": {"type": 'integer'},
-                "timeout": {"type": 'integer'},
-                "role": {"type": 'string'},
+                "server_type": {"type": 'str', "choices": ["AAA", "ISE"]},
+                "server_ip_address": {"type": 'str'},
+                "shared_secret": {"type": 'str'},
+                "protocol": {"type": 'str', "choices": ["TACACS", "RADIUS", "RADIUS_TACACS"]},
+                "encryption_scheme": {"type": 'str'},
+                "message_authenticator_code_key": {"type": 'str'},
+                "encryption_key": {"type": 'str'},
+                "authentication_port": {"type": 'int'},
+                "accounting_port": {"type": 'int'},
+                "retries": {"type": 'int'},
+                "timeout": {"type": 'int'},
+                "role": {"type": 'str'},
                 "pxgrid_enabled": {"type": 'bool'},
                 "use_dnac_cert_for_pxgrid": {"type": 'bool'},
                 "cisco_ise_dtos": {
                     "type": 'list',
-                    "user_name": {"type": 'string'},
-                    "password": {"type": 'string'},
-                    "fqdn": {"type": 'string'},
-                    "ip_address": {"type": 'string'},
-                    "description": {"type": 'string'},
-                    "ssh_key": {"type": 'string'},
+                    "user_name": {"type": 'str'},
+                    "password": {"type": 'str'},
+                    "fqdn": {"type": 'str'},
+                    "ip_address": {"type": 'str'},
+                    "description": {"type": 'str'},
+                    "ssh_key": {"type": 'str'},
                 },
                 "external_cisco_ise_ip_addr_dtos": {
                     "type": 'list',
                     "external_cisco_ise_ip_addresses": {
                         "type": 'list',
-                        "external_ip_address": {"type": 'string'},
+                        "external_ip_address": {"type": 'str'},
                     },
-                    "ise_type": {"type": 'string'},
+                    "ise_type": {"type": 'str'},
                 },
                 "trusted_server": {"type": 'bool'},
-                "ise_integration_wait_time": {"type": 'integer'}
+                "ise_integration_wait_time": {"type": 'int'}
             }
         }