Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: multiple model fixes #37

Merged
merged 9 commits into from
Feb 7, 2025
Merged

dev: multiple model fixes #37

merged 9 commits into from
Feb 7, 2025

Conversation

sbasan
Copy link
Collaborator

@sbasan sbasan commented Feb 6, 2025 •
edited
Loading

Pull Request summary:

multiple model fixes

Description of changes:

  • add src/dst security group as firewall match entries
  • allow additional highSpeedLogging field format in security policy settings
  • target vpn uid is optional in dns security policy definition
  • path preference is optional in preferred color group list
  • media profile dmtf is a list and can have default option type
  • allow ike_remote_id to be IPv4Address in lan/vpn/interface/ipsec parcel

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@sbasan sbasan changed the title dev: security policy fixes dev: multiple policy fixes Feb 6, 2025
@sbasan sbasan changed the title dev: multiple policy fixes dev: multiple model fixes Feb 6, 2025
@sbasan sbasan marked this pull request as ready for review February 7, 2025 11:28
@sbasan sbasan merged commit a076250 into dev Feb 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrajewski jpkrajewski jpkrajewski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbasan @jpkrajewski