Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull upstream changes from skeleton-generic. #23

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Nov 5, 2019

Pull in upstream changes to pre-commit versions. This was done specifically because of a bug in flake8 referenced in the upstream PR cisagov/skeleton-generic#21

Also removed the virtualenv pinning as noted in #21 as that ansible-lint issue was resolved upstream.

@mcdonnnj mcdonnnj requested review from felddy, jsf9k, dav3r and a team November 5, 2019 17:10
@mcdonnnj mcdonnnj self-assigned this Nov 5, 2019
Copy link
Member

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at all them checks!
✅ ✅ ✅ ✅ ✅ ✅ ✅

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

…nsible-lint and the updated version is included in the version being used now.
@mcdonnnj mcdonnnj merged commit 414b6fc into develop Nov 5, 2019
@mcdonnnj mcdonnnj deleted the pull_upstream_changes_2019-11-05 branch November 5, 2019 18:41
felddy added a commit that referenced this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants