Improvement GitHub Actions / Fix admin user existing #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_autoupdate Add updates from running pre-commit autoupdate
Replace Travis-CI with GitHub actions
…provement/actions
We are now have access to more state via actions
The user we delete is being recreated by cloud-init at boot.
Replaces users: - default with: users: []
dav3r
approved these changes
Oct 25, 2019
| @@ -67,7 +67,7 @@ repos: | |||
| hooks: | |||
| - id: black | |||
| - repo: https://github.com/ansible/ansible-lint.git | |||
| rev: v4.1.1a0 | |||
| rev: 7a2221a32968f12bee8494caf978ce150ad1494f | |||
There was a problem hiding this comment.
Can you open an issue to remind us to change this back to a release (when one becomes available)?
There was a problem hiding this comment.
I'm going to backport this change up to skeleton-generic. I'll modify the issue that is up there: cisagov/skeleton-generic#19
DRYs out the code a bit, and removes the need to bump tools versions in all repos.
mcdonnnj
approved these changes
Oct 25, 2019
jsf9k
reviewed
Oct 27, 2019
| --time-cond "${CURL_CACHE_DIR}/${PACKER_ZIP}" --location \ | ||
| "https://releases.hashicorp.com/packer/${PACKER_VERSION}/${PACKER_ZIP}" | ||
| sudo unzip -o -d /usr/local/bin "${CURL_CACHE_DIR}/${PACKER_ZIP}" | ||
| - name: Install Terraform |
There was a problem hiding this comment.
Could the install of packer and terraform be broken out into a separate repo a la what you did with cisagov/setup-env-github-action?
Seems maybe the Ansible role stuff could possibly be broken out as well, taking the list of role names as an input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues:
packer.jsonfile. Having separate workflows allows all variables to be adjusted, instead of relying on logic within the patcher script. With this flexibility we will be able to easily deploy pre-releases to a staging account (playground), and full releases to production.adminuser configured. This user is used by Packer. The user was persisting on to the final image with its ssh keys installed in bothadminandroot. At the end of image creation, this user is now deleted, its sudo privileges revoked, and its keys are removed fromroot. (All keys are removed fromroot.) Additionally, the cloud-init configuration is modified to prevent the user from being recreated at boot.