Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset search term with Clear All Filters button (CRASM-2246) #800

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Reset search term with Clear All Filters button (CRASM-2246) #800

merged 3 commits into from
Feb 20, 2025

Conversation

hawkishpolicy
Copy link
Collaborator

@hawkishpolicy hawkishpolicy commented Feb 19, 2025 •
edited
Loading

  • Reset search term and filters in Filter Drawer with Clear All Filters button

🗣 Description

  • Refactored Clear All Filters button to use setSearchTerm function to reset search term to an empty string and clear filters.
  • This change renders clearFilters function unnecessary and has been removed.
  • Removed clearFilters function from FilterDrawerV2.tsx, DrawerInterior.tsx, Risk.tsx, and Inventory.tsx.
  • Cleaned up html and css in DrawerInterior.tsx.

💭 Motivation and context

  • Closes CRASM-2246

🧪 Testing

  • tested locally

📷 Screenshots (if appropriate)

Screenshot 2025-02-19 at 4 19 30 PM Screenshot 2025-02-19 at 4 20 20 PM Screenshot 2025-02-19 at 4 20 33 PM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@hawkishpolicy
Reset search term with Clear All Filters button
c93a2de 
- Refactored Clear All Filters button to use setSearchTerm function to reset search term to an empty string and clear filters.
- This change renders clearFilters function unnecessary and has been removed.
- Removed clearFilters function from FilterDrawerV2.tsx, DrawerInterior.tsx, Risk.tsx, and Inventory.tsx.
- Cleaned up html and css in DrawerInterior.tsx.
@hawkishpolicy hawkishpolicy self-assigned this Feb 19, 2025
@hawkishpolicy hawkishpolicy marked this pull request as ready for review February 20, 2025 14:05
@hawkishpolicy
Edit filter clearing logic
a9fd938 
- Region and Organization filters are not reset when advanced filters are cleared.
- Edited button text to from "Clear All Filters" to "Clear Filters".
- Button only remders when advanced filters are applied.
@hawkishpolicy
Added searchTerm to selectedFiltersAndSearch
9980901
cduhn17
cduhn17 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done in group review

rapidray12
rapidray12 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done in a group review

@rapidray12 rapidray12 merged commit 708223e into develop Feb 20, 2025
13 of 14 checks passed
@rapidray12 rapidray12 deleted the Fix-Clear-Search-Bar-CRASM-2246 branch February 20, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cduhn17 cduhn17 cduhn17 approved these changes

@rapidray12 rapidray12 rapidray12 approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees

@hawkishpolicy hawkishpolicy

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkishpolicy @cduhn17 @rapidray12