-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create scan to sync WAS finding data between environments #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add shodan and xpanse mdl syncs to XFD
Create scan that pulls credential breaches from the commercial mdl
pin pytz version
Run linter
remove unnecessary else statements
Merge develop into working branch
remove pytz library
fix data_source reference, that was accessing the wrong dictionary
pylint fixes
final lint changes
Clean up comments
update scan list in the frontend
Fix failing timezone call, which was calling from the wrong datetime object
Add logging for failed runs
Remove test break statements and add additional response handling
Add WAS dmz sync
Merge scan sync branch into was Sync branch
run linter on WAS sync
remove unused model imports
lint on unrelated files
update date function to allow None return
update scan to pull more often
cduhn17
reviewed
Feb 20, 2025
cduhn17
reviewed
Feb 20, 2025
cduhn17
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments regarding repeated code
remove duplicate code for headers and date calculations
run linter and update reused variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR creates a scan that pulls WAS findings from the scanning environment and saves it to the LZ mini data lake.
💭 Motivation and context
This allows us to keep the commercial and gov cloud environments WAS finding data in sync and will allow the Cyhy Dashboard to query these findings in a more robust manner, instead of being forced into the current generic crossfeed vulnerability.
🧪 Testing
Tested locally against the live API endpoint.
✅ Pre-approval checklist
in code comments.
✅ Pre-merge checklist