Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Email Sender profile exists when creating EC2 #780

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Jan 30, 2025

🗣 Description

Ensure every resource that aws_instance needs is in the depends on and only call the profile is the count= 1.

💭 Motivation and context

Failing to apply terraform.

🧪 Testing

Terraform plan passes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once more for posterity

@cduhn17 cduhn17 merged commit bafbb07 into develop Jan 30, 2025
13 of 17 checks passed
@cduhn17 cduhn17 deleted the AL-email-EC2 branch January 30, 2025 20:52
@cduhn17 cduhn17 restored the AL-email-EC2 branch January 30, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants