Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining terraform errors caused by LZ infrastructure merge #764

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Jan 16, 2025

🗣 Description

This fixes the 3 terraform errors below:

  1. Makes sure we aren't changing the volume of the ELK EC2 (reminder this is only created in the DMZ)
  2. Makes sure the cognito email is correct and verified (was being changed to staging-cd.crossfeed... which is not verified. Keep it staging.crossfeed...)
  3. MariaDB does not support IAM Database Authentication, so sets the iam_database_authentication_enabled parameter to false

💭 Motivation and context

Screenshot 2025-01-16 at 1 15 05 PM

🧪 Testing

Passes pre-commits and github checks

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Copy link
Contributor

@Matthew-Grayson Matthew-Grayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rapidray12 rapidray12 merged commit 072f2d2 into develop Jan 16, 2025
11 of 17 checks passed
@rapidray12 rapidray12 deleted the AL-fix-teraform branch January 16, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants