Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python api-keys Endpoint Bugfix #725

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

nickviola
Copy link
Collaborator

@nickviola nickviola commented Nov 14, 2024

🗣 Description

Resolves CRASM-873

Fixes python api-keys endpoint and removes Model validation errors. Also masks unnecessary keys in response for security best practice.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@nickviola nickviola requested a review from JCantu248 November 14, 2024 21:29
@nickviola nickviola changed the title Fix api-keys endpoint by updating api method response and schema model Python api-keys Endpoint Bugfix Nov 14, 2024
@nickviola nickviola marked this pull request as ready for review November 14, 2024 21:38
@nickviola nickviola self-assigned this Nov 14, 2024
@nickviola nickviola merged commit 0dfc4d8 into AL-python-serverless Nov 15, 2024
5 of 8 checks passed
@nickviola nickviola deleted the NV-python-api-key-endpoint-fixes branch November 15, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant