Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Auth Updates #714

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Python Auth Updates #714

merged 5 commits into from
Nov 14, 2024

Conversation

nickviola
Copy link
Collaborator

@nickviola nickviola commented Nov 5, 2024

🗣 Description

Closes CRASM-851

Update to fix auth:

  • Remove requirement for "Bearer " in Authorization header and allow for usage with or without.
  • Allow either header "Authorization" or "X-API-KEY" and not require both

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@nickviola nickviola self-assigned this Nov 5, 2024
@nickviola nickviola requested a review from JCantu248 November 13, 2024 17:58
@nickviola nickviola marked this pull request as ready for review November 13, 2024 17:59
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Matthew-Grayson Matthew-Grayson self-requested a review November 14, 2024 16:02
@nickviola nickviola merged commit a9a0d02 into AL-python-serverless Nov 14, 2024
5 of 8 checks passed
@nickviola nickviola deleted the NV-python-auth-updates branch November 14, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants