Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add User Endpoints #713

Merged
merged 19 commits into from
Nov 21, 2024
Merged

Add User Endpoints #713

merged 19 commits into from
Nov 21, 2024

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Oct 31, 2024 •
edited
Loading

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Matthew-Grayson and others added 13 commits October 10, 2024 10:29
@Matthew-Grayson
Add delete_user endpoint.
017d442
@Matthew-Grayson
Add Accept Terms Endpoint.
0222f97 
Add accept_terms function to api_methods/user.py
Add /users/acceptTerms endpoint to views.py
Add UpdateUser class to schema_models/user.py
Add can_access_user function to auth.py
@Matthew-Grayson
Modify and reorder delete user endpoint; add todos for authentication…
40b2c30 
… and permissions.
@Matthew-Grayson
Add Update Users Endpoint
df742ac 
Add update users endpoint to views
Add update users definition to api_methods/user.py
Refactor user endpoints to use Request object for passing arguments
@Matthew-Grayson
Merge branch 'AL-python-serverless' of github.com:cisagov/XFD into MG…
d153303 
…-python-serverless
@Matthew-Grayson
Update User Models and Endpoints; Update Input Validation for Update …
72269af 
…User Endpoints.
@Matthew-Grayson
Add send_email Helper Functions.
f333d2b
@Matthew-Grayson
Merge branch 'AL-python-serverless' of github.com:cisagov/XFD into MG…
98014d4 
…-python-serverless
@Matthew-Grayson
Add get users by state and get users by region endpoints.
0cc85d3
@aloftus23
Add register endpoints and post User with tests in test_user.py
7195c90
@Matthew-Grayson
Update python user endpoints.
6e6d527
@Matthew-Grayson
Merge origin MG-python-serverless into remote MG-python-serverless.
12ec1aa
@Matthew-Grayson
Merge origin MG-python-serverless into remote MG-python-serverless.
0e43828
@Matthew-Grayson Matthew-Grayson self-assigned this Oct 31, 2024
cduhn17
cduhn17 reviewed Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@Matthew-Grayson
Refactor User Endpoints to Follow Best Practice
d6ea71e 
Add user context and permissions to delete_user and remove associated todo
Move non-data/service connections outside of try blocks
Replace os.getenv() calls with settings() in email.py
Add regional admin permission checks to can_access_user in auth.py
@Matthew-Grayson
Merge branch 'AL-python-serverless' of github.com:cisagov/XFD into MG…
143f8d1 
…-python-serverless
@Matthew-Grayson
Revert Deleted User Endpoints
c1545e1
nickviola
nickviola approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@nickviola nickviola left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we still need the invitation email stuff, but we can address later in a SPIKE ticket. Otherwise this LGTM

aloftus23
aloftus23 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Matthew-Grayson Matthew-Grayson merged commit 66bc973 into AL-python-serverless Nov 21, 2024
4 of 8 checks passed
@Matthew-Grayson Matthew-Grayson deleted the MG-python-serverless branch November 21, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cduhn17 cduhn17 cduhn17 left review comments

@nickviola nickviola nickviola approved these changes

@aloftus23 aloftus23 aloftus23 approved these changes

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees

@Matthew-Grayson Matthew-Grayson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Matthew-Grayson @nickviola @aloftus23 @cduhn17