Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stats endpoints, settings and management commands #707

Merged
merged 11 commits into from
Nov 20, 2024

Conversation

cduhn17
Copy link
Collaborator

@cduhn17 cduhn17 commented Oct 30, 2024

🗣 Description

Merge the methods to get stats infor for the frontend into the main backend python branch. Also includes includes updates to settings to centralize env variables to be used in API endpoints, tasks that will be run to populate AWS elasticache and supporting management commands that if in the event we need to manually push new data to elasticache

💭 Motivation and context

This change is required to add functionality to the stats endpoints.

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@cduhn17 cduhn17 self-assigned this Oct 30, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secret key in the source code = No Bueno!!!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the key is removed

@cduhn17 cduhn17 marked this pull request as ready for review November 7, 2024 13:30
@cduhn17 cduhn17 merged commit 61f9fd8 into AL-python-serverless Nov 20, 2024
4 of 8 checks passed
@cduhn17 cduhn17 deleted the cd_elasticache_updated branch November 20, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants