Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Controls 12.1: correct Policy API implementation #539

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

rlxdev
Copy link
Collaborator

@rlxdev rlxdev commented Dec 23, 2024

🗣 Description

The implementation of the Common Controls 12.1 baseline using the Policy API has been fixed to give the correct results.
The initial implementation assumed a link between the "services without an individual admin control" and the individual takeout admin controls.

Closes #530

🧪 Testing

The tests for the Policy API implementation of Common Controls 12.1 have been updated to reflect the correct takeout setting functionality. The changes were made in commoncontrols_api12_test.rego.

The takeout settings were altered using the scubagws Admin UI to confirm that the correct result was produced by ScubaGoggles.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@rlxdev rlxdev added bug This issue or pull request addresses broken functionality Common Controls labels Dec 23, 2024
@rlxdev rlxdev force-pushed the 519-policy-api-updates branch from 484e88d to 67abc58 Compare January 9, 2025 20:36
@rlxdev rlxdev force-pushed the 530-fix-takeout-services branch from a822140 to 1a4ca96 Compare January 9, 2025 20:49
@rlxdev rlxdev added this to the Driftwood milestone Jan 13, 2025
Base automatically changed from 519-policy-api-updates to main February 5, 2025 19:43
@rlxdev rlxdev force-pushed the 530-fix-takeout-services branch from 1a4ca96 to d672ec6 Compare February 5, 2025 21:05
@rlxdev rlxdev marked this pull request as ready for review February 5, 2025 21:07
@prodjom prodjom requested review from adhilto, snarve and buidav and removed request for adhilto and snarve February 10, 2025 17:59
Copy link
Collaborator

@snarve snarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@snarve snarve merged commit 272a04a into main Feb 11, 2025
10 checks passed
@snarve snarve deleted the 530-fix-takeout-services branch February 11, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality Common Controls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct bug with takeout for services without individual admin controls
3 participants