-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sample reports for 1.5.0 #1566
Update sample reports for 1.5.0 #1566
Conversation
33d2609
to
970a635
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 quick questions besides that I didn't see any issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked conditional access policies, privileged users/roles and found no outliers.
Checked for application/service principal object/application IDs and found no outliers across privileged_service_principals
, risky_applications
, or risky_third_party_service_principals
properties.
@nanda-katikaneni Updated sample reports are ready for merge. |
🗣 Description
Replaces the old sample reports with newly generated versions that incorporate changes and updates made up to v1.5.0, including:
💭 Motivation and context
Sample reports can be referenced by users to better understand what sort of output the tool can generate. This version includes additional result and report information from assessment updates.
Closes #1558
🧪 Testing
Sample reports were generated against a test tenant and an automated redaction script followed by manually editing the JSON to sanitize any user and tenant details. Then,
Invoke-ScubaCached -Login:$false -ExportProvider:$false -M365Environment gcc -ProductNames * -OutPath <sample_outfolder>
is run which will use the existing out folder's JSON file as input and replace the other output files in that directory with those from the cached run. The same command was run again with the-KeepIndividualJSON
option to generate the full range of possible output files possible depending on parameters.Test the changes by checking out a local copy of the branch and manually reviewing the JSON, CSV, and HTML output files with local editor/browser. Do note that the links to SCBs in the HTML report will generate a 404 Not Found until the actual release is published since the tag doesn't yet exist. To check the links, just be sure that they are well-formed and include the v1.5.0 tag as the correct version.
✅ Pre-approval checklist
Unit tests added/updated to cover PowerShell and Rego changes.N/AFunctional tests added/updated to cover PowerShell and Rego changes.N/AAll relevant functional tests passed.N/A✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Medium
or larger)✅ Post-merge checklist