Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dark mode by removing background image temporarily #794

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

axu2
Copy link
Collaborator

@axu2 axu2 commented Dec 31, 2024

Temporarily removing background image. The background image seems to prevent the background-color from being pure white in light mode.

Removing the CSS from the messages fixes the black text on dark mode issue on macOS. This doesn't appear to be an issue on other OSs

image
image

@ctrleo I'm sorry, but I made several GUI commits recently so you'll need to resume from this base point, merge conflicts are guarenteed so may be easier to just start a new PR. The background of the box must be white in light mode. If you still want to add the icon back.

@jeffmcneill feel free to test

@axu2 axu2 changed the title fix dark mode fix dark mode by removing background image temporarily Dec 31, 2024
@axu2 axu2 merged commit 5875508 into ciromattia:master Dec 31, 2024
@axu2 axu2 deleted the dark-mode branch December 31, 2024 04:16
@jeffmcneill
Copy link

@axu2 Thanks for this, and also @ctrleo for your many efforts. I can't test as is, but if an AppImage is made available, I'll be able to.

@axu2
Copy link
Collaborator Author

axu2 commented Dec 31, 2024

@jeffmcneill
Copy link

Got an error on runtime:

[PYI-28662:ERROR] Failed to load Python shared library '/tmp/_MEIe7t95C/libpython3.11.so.1.0': dlopen: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.38' not found (required by /tmp/_MEIe7t95C/libpython3.11.so.1.0)

@axu2
Copy link
Collaborator Author

axu2 commented Dec 31, 2024

@jeffmcneill What are you running? This was built on ubuntu-22.04

@jeffmcneill
Copy link

Debian stable

    ,g$$$$$$$$$$$$$$$P.       -------- 
  ,g$$P"     """Y$$.".        OS: Debian GNU/Linux 12 (bookworm) x86_64 
 ,$$P'              `$$$.     Host: NUC8i3BEH J72753-306 
',$$P       ,ggs.     `$$b:   Kernel: 6.11.10+bpo-amd64 
`d$$'     ,$P"'   .    $$$    Uptime: 22 hours, 31 mins 
 $$P      d$'     ,    $$P    Packages: 2208 (dpkg) 
 $$:      $$.   -    ,d$$'    Shell: bash 5.2.15 
 $$;      Y$b._   _,d$P'      Resolution: 1920x1080, 1920x1080 
 Y$$.    `.`"Y$$$$P"'         DE: Xfce 4.18 
 `$$b      "-.__              WM: Xfwm4 
  `Y$$                        WM Theme: Default 
   `Y$$.                      Theme: Adwaita-dark [GTK2/3] 
     `$$b.                    Icons: gnome [GTK2/3] 
       `Y$$b.                 Terminal: xfce4-terminal 
          `"Y$b._             Terminal Font: Monospace 12 
              `"""            CPU: Intel i3-8109U (4) @ 3.600GHz 
                              GPU: Intel CoffeeLake-U GT3e [Iris Plus Graphics 655] 
                              Memory: 3301MiB / 15858MiB 

@jeffmcneill
Copy link

Also:

  • ldd --version: ldd (Debian GLIBC 2.36-9+deb12u9) 2.36
  • python3 --version: Python 3.11.2

@axu2
Copy link
Collaborator Author

axu2 commented Jan 1, 2025

@shaicoleman do you have any insight?

@shaicoleman
Copy link

shaicoleman commented Jan 1, 2025

@axu2 , The AppImage should probably include glibc to work better across distros.
The revert changed it to ubuntu-latest. Maybe ubuntu-22.04 would work better.
That said, I'm currently using the flatpak version, as v6 does everything I need.

@axu2
Copy link
Collaborator Author

axu2 commented Jan 1, 2025

@shaicoleman Currently, ubuntu-latest refers to 22.04. https://github.com/actions/runner-images?tab=readme-ov-file#available-images

Do you think adding glibc to this line would fix the issue?

sudo apt-get install -y libpng-dev libjpeg-dev p7zip-full p7zip-rar python3-pip squashfs-tools libfuse2 libxcb-cursor0

Feel free to fork KCC, enable GitHub Actions on your fork, and run the linux action to build and download an appimage from GitHub servers. @jeffmcneill

@axu2
Copy link
Collaborator Author

axu2 commented Jan 4, 2025

@jeffmcneill @shaicoleman 7.1.1 is now on flat hub.

@shaicoleman
Copy link

@axu2 , thanks, the flatpak works well for me

@jeffmcneill
Copy link

jeffmcneill commented Jan 5, 2025

@axu2 I don't use flatpaks, so I'll stick with the non-dark mode release until the appimage works again, or even better this is released as a Deb.

@axu2
Copy link
Collaborator Author

axu2 commented Jan 7, 2025

@axu2 , The AppImage should probably include glibc to work better across distros. The revert changed it to ubuntu-latest. Maybe ubuntu-22.04 would work better. That said, I'm currently using the flatpak version, as v6 does everything I need.

@shaicoleman Currently, ubuntu-latest refers to 22.04. https://github.com/actions/runner-images?tab=readme-ov-file#available-images

@shaicoleman Turns out I was wrong. The docs say ubuntu-latest refers to 22.04 but the actual logs sometimes were building it on 24.04. That was the problem.

@jeffmcneill
Copy link

jeffmcneill commented Jan 7, 2025

@axu2 @shaicoleman Latest 7.1.2 AppImage works a charm! Thanks for hunting down that bug. I had a hunch we could blame Microsoft for the failure... -_-

I did see two error messages, but they did not impede the application:

qt.gui.imageio: libpng warning: iCCP: known incorrect sRGB profile

** (kcc_linux:99541): WARNING **: 09:31:41.226: atk-bridge: get_device_events_reply: unknown signature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark Mode (feature request)
3 participants