-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dark mode by removing background image temporarily #794
Conversation
@jeffmcneill test builds here https://github.com/ciromattia/kcc/releases/tag/v7.1.0 |
Got an error on runtime:
|
@jeffmcneill What are you running? This was built on ubuntu-22.04 |
Debian stable
|
Also:
|
@shaicoleman do you have any insight? |
@axu2 , The AppImage should probably include glibc to work better across distros. |
@shaicoleman Currently, Do you think adding kcc/.github/workflows/package-linux.yml Line 37 in 2189f4b
Feel free to fork KCC, enable GitHub Actions on your fork, and run the linux action to build and download an appimage from GitHub servers. @jeffmcneill |
@jeffmcneill @shaicoleman 7.1.1 is now on flat hub. |
@axu2 , thanks, the flatpak works well for me |
@axu2 I don't use flatpaks, so I'll stick with the non-dark mode release until the appimage works again, or even better this is released as a Deb. |
@shaicoleman Turns out I was wrong. The docs say |
@axu2 @shaicoleman Latest 7.1.2 AppImage works a charm! Thanks for hunting down that bug. I had a hunch we could blame Microsoft for the failure... -_- I did see two error messages, but they did not impede the application:
|
Temporarily removing background image. The background image seems to prevent the
background-color
from being pure white in light mode.Removing the CSS from the messages fixes the black text on dark mode issue on macOS. This doesn't appear to be an issue on other OSs
@ctrleo I'm sorry, but I made several GUI commits recently so you'll need to resume from this base point, merge conflicts are guarenteed so may be easier to just start a new PR. The background of the box must be white in light mode. If you still want to add the icon back.
@jeffmcneill feel free to test