Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify cover upload on newer MTP based Kindles by replacing EBOK with PDOC #767

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

axu2
Copy link
Collaborator

@axu2 axu2 commented Nov 3, 2024

Test builds:

https://github.com/axu2/kcc/releases/tag/v6.2.1-pdoc

https://github.com/axu2/kcc/releases/tag/v6.2.1-comicrack-pdoc

https://github.com/axu2/kcc/releases/tag/v6.3.0

The Kindle Colorsoft has been reported to not expose the system/thumbnails folder for covers, so here's a workaround and pre-built exe.

It just replaces EBOK tag with PDOC, so Kindle reads the cover directly from the file. Please test and tell me if it has issues.

Also, should I remove the ASIN tag?

And does anyone remember when pdoc covers started being read by Kindles? @Zappy86

@AcidWeb
Copy link
Collaborator

AcidWeb commented Nov 3, 2024

Please research this topic before blindly messing with headers. This affect a lot of things other than covers.

@axu2
Copy link
Collaborator Author

axu2 commented Nov 3, 2024

@AcidWeb Is there a list anywhere of differences? All I know is that EBOK was required in the past for covers but that isn't true now.

@AcidWeb
Copy link
Collaborator

AcidWeb commented Nov 3, 2024

No. It was never properly documented but it impact how e-reader handle such file. Covers are just a tip of the iceberg.

@axu2
Copy link
Collaborator Author

axu2 commented Nov 3, 2024

I see. I'll continue testing the files generated with this change and asking for feedback from testers. All I know is that EBOK was required in the past for covers but that isn't true now.

But for now my Scribe seems to read it just fine.

@AcidWeb
Copy link
Collaborator

AcidWeb commented Nov 3, 2024

If you plan to switch to PDOC then in general can drop entire code that modify headers and send cover thumbnails.

@axu2
Copy link
Collaborator Author

axu2 commented Nov 3, 2024

Will need to leave that code in for older kindles that can only get covers for EBOK. On mobile read a user confirmed it's still needed for kindle voyage on latest firmware.

@axu2 axu2 marked this pull request as draft November 4, 2024 15:29
@axu2
Copy link
Collaborator Author

axu2 commented Nov 5, 2024

Will tentatively force pdoc for these models:

    ProfilesKindlePDOC = {
        'KO': ("Kindle Oasis 2/3/Paperwhite 12/Colorsoft 12", (1264, 1680), Palette16, 1.8),
        'K11': ("Kindle 11", (1072, 1448), Palette16, 1.8),
        'KPW5': ("Kindle Paperwhite 5/Signature Edition", (1236, 1648), Palette16, 1.8),
        'KS': ("Kindle Scribe", (1860, 2480), Palette16, 1.8),
    }

Only way to get covers on colorsoft, doesn't require workaround for mtp based kindles. And a few extra ones that support pdoc covers.

@axu2 axu2 marked this pull request as ready for review November 5, 2024 20:09
@axu2 axu2 changed the title simplify covers by replacing ebok with pdoc simplify cover upload on newer MTP based Kindles by replacing EBOK with PDOC Nov 8, 2024
@axu2 axu2 merged commit 78c014b into ciromattia:master Nov 8, 2024
@axu2 axu2 deleted the pdoc branch November 8, 2024 05:54
@asilentdreamer
Copy link

Kindle 11th gen (2022) does not use MTP, its just 11th gen (2024). Will there be an option to distinguish between the two?

@axu2
Copy link
Collaborator Author

axu2 commented Nov 12, 2024

@asilentdreamer is there any reason to distinguish? It should still be able to read cover from PDOC. New method, you don't need to leave kindle plugged in.

@asilentdreamer
Copy link

I see. In that case there doesn't seem to be one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants