Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of bug fixes and improvements for mobile devices #7

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

makermelissa
Copy link
Collaborator

Depends on adafruit/ble-file-transfer-js#5.

Here's some features of the new features:

  • Works with the following fix: Split listdir entries across two packets adafruit/circuitpython#5524.
  • Works on mobile devices without crashing.
  • Height adjustment fix for mobile devices
  • Improved color scheme so it's actually readable.
  • Connect no longer tries to bond, making reconnecting much simpler.
  • Busy indicator during bluetooth transactions.
  • Better Error Handling.
  • Mobile Menu items are now fixed
  • Disconnect button works properly on mobile
  • When opening another file or starting a new document and the current file isn't saved, you now get a choice of saving, discarding, or cancelling.
  • Minor bug fixes related to the file dialog.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for polishing things up.

@makermelissa
Copy link
Collaborator Author

Ok, it's passing now. I don't have merge rights on here, so you'll have to do it.

@tannewt tannewt merged commit e9c352d into circuitpython:main Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants