workerpool: refactor results to avoid unnecessary copy #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background: To avoid leaking the internal implementation of the task struct, WorkPool.Drain() return a slice of Task interface. Before this patch, the WorkPool struct would maintain a slice of concret task struct pointers to be used as return value for the Drain() method. Since Drain() returns a slice of Task interface, a conversion was required. This patch make it so the WorkPool results is a slice of Task interface instead. That way it can be returned as-is by Drain(). Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
rolinh
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: To avoid leaking the internal implementation of the
task struct,WorkPool.Drain()return a slice ofTask interface.Before this patch, the
WorkPool structwould maintain a slice of concrettask structpointers to be used as return value for theDrain()method. SinceDrain()returns a slice ofTask interface, a conversion was required.This patch make it so the
WorkPoolresults is a slice ofTask interfaceinstead. That way it can be returned as-is byDrain().