Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/sensors: pin link in TracingAttach #3352

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Jan 29, 2025

Links were not pinned to the fs and thus --keep-sensors-on-exit was not working with program using such attach mechanism since they were garbage collected by the kernel on closing the file descriptor.

@mtardy mtardy added the release-note/misc This PR makes changes that have no direct user impact. label Jan 29, 2025
@mtardy mtardy requested a review from a team as a code owner January 29, 2025 15:09
@mtardy mtardy requested a review from will-isovalent January 29, 2025 15:09
@mtardy mtardy force-pushed the pr/mtardy/tracing-attach-pin-link branch 2 times, most recently from ee72b9a to 062983f Compare January 29, 2025 15:13
@mtardy mtardy requested a review from olsajiri January 29, 2025 15:13
Links were not pinned to the fs and thus --keep-sensors-on-exit was not
working with program using such attach mechanism since they were garbage
collected by the kernel on closing the file descriptor.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
@mtardy mtardy force-pushed the pr/mtardy/tracing-attach-pin-link branch from 062983f to 8233b78 Compare January 29, 2025 15:19
Copy link
Contributor

@olsajiri olsajiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mtardy mtardy merged commit 064db3e into main Jan 29, 2025
39 checks passed
@mtardy mtardy deleted the pr/mtardy/tracing-attach-pin-link branch January 29, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants