Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase loop iteration count in event_find_curr function #3259

Closed
wants to merge 1 commit into from

Conversation

arthur-zhang
Copy link
Contributor

@arthur-zhang arthur-zhang commented Dec 25, 2024

Maybe current loop count is too small.

Description

For example, in the popular orbstack(https://orbstack.dev/) implementation. Starting from the current process to the process with pid 1, it takes 5 steps to find the parent processes. Change the loop count to a higher value make tetragon work in orbstack vms.

zsh-79260   [007] ....1 80569.428901: bpf_trace_printk: >>>>__event_find_parent: fork, pid=28997, value is null:1
 zsh-79260   [007] ....1 80569.428901: bpf_trace_printk: >>>>__event_find_parent: fork, pid=544, value is null:1
 zsh-79260   [007] ....1 80569.428902: bpf_trace_printk: >>>>__event_find_parent: fork, pid=508, value is null:1
 zsh-79260   [007] ....1 80569.428902: bpf_trace_printk: >>>>__event_find_parent: fork, pid=507, value is null:1
 zsh-79260   [007] ....1 80569.428902: bpf_trace_printk: >>>>__event_find_parent: fork, pid=1, value is null:0

Changelog

increase loop iteration count in event_find_curr function from 4 to 8

Signed-off-by: arthur-zhang <happyzhangya@gmail.com>
@arthur-zhang arthur-zhang requested a review from a team as a code owner December 25, 2024 13:53
@arthur-zhang arthur-zhang requested a review from tixxdz December 25, 2024 13:53
@mtardy
Copy link
Member

mtardy commented Jan 2, 2025

Hey, seeing this PR now, what made you closed it in the end, the problem was resolved?

@arthur-zhang
Copy link
Contributor Author

arthur-zhang commented Jan 3, 2025

I found that maybe I misunderstand some code, so i close the pr. Sorry for bother you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants