crd: Fix type mismatch warning #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jrfastab
reviewed
Jan 17, 2024
jrfastab
reviewed
Jan 17, 2024
pkg/watcher/crd/watcher.go
Outdated
| @@ -143,6 +141,7 @@ func updateTracingPolicy(ctx context.Context, log logrus.FieldLogger, s *sensors | |||
| "new": newTp.TpName(), | |||
| }).Info("updating tracing policy") | |||
| update(oldTp, newTp) | |||
| return | |||
There was a problem hiding this comment.
hmm rather than putting more returns here maybe we could have update return an error and then if (err) ... print the warning?
There was a problem hiding this comment.
Yes, this may be a cleaner solution there. I will try to make that better.
There was a problem hiding this comment.
Updated that a bit. The error is not due to the update but on the different types of tracing policies. I believe it is cleaner now.
There was a problem hiding this comment.
ah that is much clearer to me what the issue was. thanks.
When we update a tracing policy (i.e. apply a policy with the same name as an existing policy), we check if the new tracing policy has the same type (i.e. TracingPolicy or TracingPolicyNamespaced) as the old one. Now we print the warning about type mismatch even if the types are the same. This patch fixes that by returing right after the actual update. Signed-off-by: Anastasios Papagiannis <tasos.papagiannnis@gmail.com>
2fd5e5c to
e0b1dce
Compare
jrfastab
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we update a tracing policy (i.e. apply a policy with the same name as an existing policy), we check if the new tracing policy has the same type (i.e. TracingPolicy or TracingPolicyNamespaced) as the old one.
Now we print the warning about type mismatch even if the types are the same. This patch fixes that by returing right after the actual update.