Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor docs changes for 1.0 messaging #1673

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Minor docs changes for 1.0 messaging #1673

merged 1 commit into from
Oct 31, 2023

Conversation

hacktivist123
Copy link
Member

Fixes: #1672

@hacktivist123 hacktivist123 requested review from mtardy and a team as code owners October 30, 2023 11:39
@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 4ca4d6a
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/65411460b1b0ea0008a2f114
😎 Deploy Preview https://deploy-preview-1673--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kkourt kkourt added the release-note/docs This PR updates the documentation. label Oct 30, 2023
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! two minor nits based on the changes proposed in #1672. i guess we are referring to tetragon as "Cilium Tetragon".

@@ -4,10 +4,10 @@ linkTitle: "Overview"
weight: 1
icon: "overview"
description: >
Discover Tetragon and its capabilities
Discover Cilium's Tetragon and its capabilities
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Discover Cilium's Tetragon and its capabilities
Discover Cilium Tetragon and its capabilities

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizrice can you clarify this? i was a bit confused, how do we want to position this? is it Cilium's tetragon or Cilium tetragon?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Cilium Tetragon" is correct, so Michi's suggested changes are good

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh thanks, I was a bit confused on if we are now calling it Cilium Tetragon or if we want to indicate that it's a part of Cilium by just saying Cilium's Tetragon.

@michi-covalent i've committed the change

docs/layouts/partials/footer.html Outdated Show resolved Hide resolved
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please squash these two commits 🙏

Fixes: #1672

Signed-off-by: Shedrack Akintayo <akintayoshedrack@gmail.com>
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing that!

@mtardy mtardy merged commit 9b549dc into cilium:main Oct 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor docs changes for clarifying Tetragon as part of Cilium
5 participants