-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor docs changes for 1.0 messaging #1673
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix! two minor nits based on the changes proposed in #1672. i guess we are referring to tetragon as "Cilium Tetragon".
@@ -4,10 +4,10 @@ linkTitle: "Overview" | |||
weight: 1 | |||
icon: "overview" | |||
description: > | |||
Discover Tetragon and its capabilities | |||
Discover Cilium's Tetragon and its capabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discover Cilium's Tetragon and its capabilities | |
Discover Cilium Tetragon and its capabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lizrice can you clarify this? i was a bit confused, how do we want to position this? is it Cilium's tetragon or Cilium tetragon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Cilium Tetragon" is correct, so Michi's suggested changes are good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh thanks, I was a bit confused on if we are now calling it Cilium Tetragon or if we want to indicate that it's a part of Cilium by just saying Cilium's Tetragon.
@michi-covalent i've committed the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM please squash these two commits 🙏
Fixes: #1672 Signed-off-by: Shedrack Akintayo <akintayoshedrack@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing that!
Fixes: #1672