tetragon: for now drop benchmark section #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think we need Benchmark section for next release and I think we should spend some time on how to do repeatable benchmarks vs simply push this into the pages. So delete section now and stay tuned for a better implementation. Signed-off-by: John Fastabend <john.fastabend@gmail.com>
mtardy
previously approved these changes
Oct 20, 2023
oh no you also need to update the refs to this page that are no broken, see https://github.com/cilium/tetragon/actions/runs/6591111808/job/17909074672?pr=1631#step:7:10
f3d83a4 to
8560088
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mtardy
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need Benchmark section for next release and I think we should spend some time on how to do repeatable benchmarks vs simply push this into the pages.
So delete section now and stay tuned for a better implementation.