-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon: Add support to pass options through spec #1626
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsajiri
force-pushed
the
pr/olsajiri/options_spec
branch
from
October 20, 2023 08:17
4dd6ad7
to
ae43818
Compare
olsajiri
added
the
release-note/minor
This PR introduces a minor user-visible change
label
Oct 20, 2023
olsajiri
force-pushed
the
pr/olsajiri/options_spec
branch
3 times, most recently
from
October 24, 2023 18:01
775b501
to
33a8706
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
olsajiri
force-pushed
the
pr/olsajiri/options_spec
branch
5 times, most recently
from
October 25, 2023 07:43
11f7240
to
1153968
Compare
tpapagian
reviewed
Oct 26, 2023
tpapagian
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have some small comments but nothing critical.
Removing GenericTracepointConf type as a cleanup, because that abstraction is not actually needed anywhere. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding possibility to specify option for the set. It's an array of name/value pairs and it's meant to be processed and interpreted by each sensor. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
We are about to pass options to createGenericKprobeSensor function, so it's better the function takes the whole spec poitner rather than adding another function argument. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding support to process options passed in spec for kprobe sensor. At the moment the only supported option is to disable kprobe multi (like with --disable-kprobe-multi option). Signed-off-by: Jiri Olsa <jolsa@kernel.org>
We can now localy disable kprobe multi, let's use it for security_ override test, which won't work with kprobe multi. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/options_spec
branch
from
October 30, 2023 07:20
1153968
to
c9a7614
Compare
kkourt
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support to process options passed in spec for kprobe sensor.
At the moment the only supported option is to disable kprobe multi
(like with --disable-kprobe-multi option).