Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: fix cilium/tetragon replacement in api #1612

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

willfindlay
Copy link
Contributor

We had ../../tetragon as the go mod replacement for the api module. But what happens when the directory name of the git repo isn't tetragon? We should handle this case, so change it to .. directly.

We had `../../tetragon` as the go mod replacement for the api module. But what happens
when the directory name of the git repo isn't `tetragon`? We should handle this case, so
change it to `..` directly.

Signed-off-by: William Findlay <will@isovalent.com>
@willfindlay willfindlay requested a review from a team as a code owner October 18, 2023 16:34
@willfindlay willfindlay added the release-note/misc This PR makes changes that have no direct user impact. label Oct 18, 2023
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure if it works

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I came upon this weird thing when writing the one for this

replace github.com/cilium/tetragon/api => ../../../api
.

@willfindlay willfindlay merged commit 69d2d36 into main Oct 18, 2023
@willfindlay willfindlay deleted the pr/willfindlay/fix-mod-vendoring branch October 18, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants