Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alignchecker: refactor into single gotest #1588

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

willfindlay
Copy link
Contributor

This series refactors the alignchecker into a single gotest to make editing the test case easier going forward.

Later patches in this series will refactor alignchecker so that we use it as a gotest only
rather than building a standalone binary. Remove the binary.

Signed-off-by: William Findlay <will@isovalent.com>
@willfindlay willfindlay requested a review from tpapagian October 12, 2023 14:16
@willfindlay willfindlay requested a review from a team as a code owner October 12, 2023 14:16
@willfindlay willfindlay added the release-note/misc This PR makes changes that have no direct user impact. label Oct 12, 2023
@willfindlay willfindlay marked this pull request as draft October 12, 2023 14:16
@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit ce6d227
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6527ffa9ab0e700008253551
😎 Deploy Preview https://deploy-preview-1588--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: William Findlay <will@isovalent.com>
This should make it easier to add new structs going forward without worrying about
changing numbering.

Signed-off-by: William Findlay <will@isovalent.com>
Signed-off-by: William Findlay <will@isovalent.com>
@willfindlay willfindlay force-pushed the pr/willfindlay/alignchecker-refactors branch from ce6d227 to aa7ab8f Compare October 12, 2023 14:28
@willfindlay willfindlay marked this pull request as ready for review October 12, 2023 14:28
@tpapagian tpapagian merged commit 02861f0 into main Oct 13, 2023
@tpapagian tpapagian deleted the pr/willfindlay/alignchecker-refactors branch October 13, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants