renovate: fix the way we manually install Go inside the runner #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplify a49c4bc that causes issues in the case of the new Go toolchain feature. It was manually installing a version off-by-one, like 1.21.2 for 1.21.3 present in the just updated go.mod and thus triggering the automatic download of the 1.21.3 toolchain. But in the renovate container env, GOSUMDB is set to off for some reason which blocks the download of the toolchain. This simplifies the manual install by reading the go.mod file to determine the correct version, allowing to remove the bump of the number in the renovate config itself. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
1 task
kkourt
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #1579 because #1577 is broken.
This simplifies a49c4bc that causes issues in the case of the new Go toolchain feature. It was manually installing a version off-by-one, like 1.21.2 for 1.21.3 present in the just updated go.mod and thus triggering the automatic download of the 1.21.3 toolchain. But in the renovate container env, GOSUMDB is set to off for some reason which blocks the download of the toolchain.
This simplifies the manual install by reading the go.mod file to determine the correct version, allowing to remove the bump of the number in the renovate config itself.