docs: fixes anchor links #1516
Merged
docs: fixes anchor links #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mtardy
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Looks good, so those are values that will need to be manually edited if we edit the height of the navbar? could you add a comment to explain that :) thanks! checkpatch finds your commit too long, I think it's missing an empty line between the commit title and the sign-off
|
@mtardy Yes, that's correct. If the header height changes, then these values need to be adjusted to maintain the same visual quality. Thank you for the feedback. I will leave comments in the code. |
026c981 to
ec13bb1
Compare
|
Can you squash your commits into the first one? |
Signed-off-by: Evgenii Sazhin <prosazhin@gmail.com>
0486c35 to
7fec0be
Compare
|
@mtardy Done, ready to check |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes anchor links in docs. Preview