Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: Call crd.RegisterCRDs() from operator deployment #1492

Merged
merged 1 commit into from
Sep 19, 2023
Merged

operator: Call crd.RegisterCRDs() from operator deployment #1492

merged 1 commit into from
Sep 19, 2023

Conversation

michi-covalent
Copy link
Contributor

  • Refactor the CRD registration logic to a separate common package so that both the root and serve commands can call it.
  • Mount tetragon-operator-config configmap for the operator deployment.

@michi-covalent
Copy link
Contributor Author

the ultimate goal is to get rid of the init container from the tetragon daemonset, and make the tetragon operator solely responsible for registering CRDs. we need to teach tetragon to wait for CRDs to get registered before we can get rid of the init container.

@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label Sep 18, 2023
@michi-covalent
operator: Call crd.RegisterCRDs() from operator deployment
d32b5c5 
- Refactor the CRD registration logic to a separate common package so
  that both the root and serve commands can call it.
- Mount tetragon-operator-config configmap for the operator deployment.
- Update the operator ClusterRole so that it can register CRDs.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent marked this pull request as ready for review September 18, 2023 22:55
@michi-covalent michi-covalent requested a review from a team as a code owner September 18, 2023 22:55
@jrfastab jrfastab merged commit 7cfc0b1 into main Sep 19, 2023
@jrfastab jrfastab deleted the pr/michi/operator branch September 19, 2023 01:51
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfastab jrfastab jrfastab approved these changes

@mtardy mtardy Awaiting requested review from mtardy mtardy is a code owner automatically assigned from cilium/tetragon

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michi-covalent @jrfastab