Reconstruct BTF types more accurately in getKernelType #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes warnings for struct/pointer-based types (e.g. file) that the spec type doesn't align with the BPF-identified type. This issue was previously identified (with a fix written) in cilium#850. However, that fix was never merged, and changes validation logic instead of just type identification. Signed-off-by: Christopher Paplham <36825497+cpaplham@users.noreply.github.com>
jrfastab
approved these changes
Oct 12, 2023
|
Thanks @cpaplham ! Sorry seems it took me a really long time to get to this I missed it in the PR lists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes warnings for struct/pointer-based types (e.g. file) that the spec type doesn't align with the BPF-identified type.
This issue was previously identified (with a fix written) in #850. However, that fix was never merged, and changes validation logic instead of just type identification.