tetragon-oci-hook: fix issue for containerd #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
containerd seems to be using a different label key for the container namespace than cri-o, which results in the fail detection of tetragon-oci-hook to not work properly because the teragon container cannot start. While this can be fixed via appropriate arguments to the hook, we also want to have it working by default. So this patch: - changes the cel expression to support multiple keys - adds the key used by containerd (io.kubernetes.cri.sandbox-namespace) to the one used by cri-o (io.kubernetes.cri.sandbox-namespace). The patch also adds a --debug option, and cleans up some dead code. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
willfindlay
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containerd seems to be using a different label key for the container namespace than cri-o, which results in the fail detection of tetragon-oci-hook to not work properly because the teragon container cannot start.
While this can be fixed via appropriate arguments to the hook, we also want to have it working by default. So this patch:
The patch also adds a --debug option, and cleans up some dead code.
This issue was reported on slack by @akshay196.