Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update go to v1.21.1 (minor) #1344

Merged
merged 2 commits into from
Sep 28, 2023
Merged

chore(deps): update go to v1.21.1 (minor) #1344

merged 2 commits into from
Sep 28, 2023

Conversation

cilium-renovate[bot]
Copy link
Contributor

@cilium-renovate cilium-renovate bot commented Aug 9, 2023

This PR contains the following updates:

Package Type Update Change
docker.io/library/golang minor 1.20.8-alpine -> 1.21.1-alpine
docker.io/library/golang final minor 1.20.8 -> 1.21.1
docker.io/library/golang stage minor 1.20.8 -> 1.21.1
go (source) minor 1.20.8 -> 1.21.1
go (source) golang minor 1.20 -> 1.21

Configuration

📅 Schedule: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@cilium-renovate cilium-renovate bot requested review from willfindlay and a team as code owners August 9, 2023 18:06
@cilium-renovate cilium-renovate bot added kind/enhancement This improves or streamlines existing functionality release-blocker This PR or issue is blocking the next release. labels Aug 9, 2023
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty recent but I think we can go for it, I'm very pleased with those automatic PRs! :) will need you ack @willfindlay

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmh I think the test failing is an actual error

@mtardy mtardy self-requested a review August 10, 2023 15:40
@cilium-renovate cilium-renovate bot force-pushed the renovate/go branch 5 times, most recently from d30afa3 to 46c9e6f Compare August 22, 2023 18:06
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestUprobePidMatch is failing consistently on arm64, need to investigate

@cilium-renovate cilium-renovate bot force-pushed the renovate/go branch 3 times, most recently from 7c8b805 to cce51c5 Compare September 6, 2023 18:12
@cilium-renovate cilium-renovate bot changed the title chore(deps): update go to v1.21.0 (minor) chore(deps): update go (minor) Sep 6, 2023
@cilium-renovate cilium-renovate bot changed the title chore(deps): update go (minor) chore(deps): update go to v1.21.1 (minor) Sep 7, 2023
@mtardy mtardy added release-note/dependency This PR updates one or multiple dependencies and removed kind/enhancement This improves or streamlines existing functionality labels Sep 7, 2023
@cilium-renovate cilium-renovate bot force-pushed the renovate/go branch 3 times, most recently from 99768d2 to d3557ab Compare September 8, 2023 09:09
@cilium-renovate cilium-renovate bot force-pushed the renovate/go branch 3 times, most recently from b9257d6 to 6ee523d Compare September 13, 2023 09:07
@mtardy
Copy link
Member

mtardy commented Sep 14, 2023

So I investigated and something happened with Go1.21 golang/go#62520 and we will need to adapt, I'll do a patch.

@cilium-renovate cilium-renovate bot force-pushed the renovate/go branch 4 times, most recently from 4f93fa2 to b93020f Compare September 21, 2023 09:11
@cilium-renovate cilium-renovate bot force-pushed the renovate/go branch 2 times, most recently from 8c3c1b0 to 3a356fa Compare September 22, 2023 09:06
Signed-off-by: cilium-renovate[bot] <134692979+cilium-renovate[bot]@users.noreply.github.com>
Go 1.21 broke dynamic symbol linking export, see more
- golang/go#62520
- golang/go#62520 (comment)

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 76f86c9
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/651558be66854b00087f6565
😎 Deploy Preview https://deploy-preview-1344--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay it works with this fix 76f86c9. Let's go Go v1.21.1!

@mtardy mtardy merged commit b387c46 into main Sep 28, 2023
@mtardy mtardy deleted the renovate/go branch September 28, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker This PR or issue is blocking the next release. release-note/dependency This PR updates one or multiple dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant