Let renovate update Go toolchain in a single PR #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Cilium builder was an unnecessary image in which we could not pre-determine the Go version inside. We can just use the standard docker.io/library/golang images and update all go version with renovate. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Also rework package rule to group workflows updates. The rule was picking up all updates to the workflows while it was intended only at updates from the github-actions managers. It generated a really weird behavior when I needed renovate to upgrade go-versions used in the workflows. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
For that, simplify the image used and use a regex to update it. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Also run go mod vendor after a go.mod directive update. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
59d8031 to
2ac15c7
Compare
kkourt
approved these changes
Jul 20, 2023
willfindlay
approved these changes
Jul 20, 2023
|
How will the CI god punish me this time? Time to merge!! 🚢 |
mtardy
added a commit
that referenced
this pull request
Oct 11, 2023
PR #1536 broke "renovate update Go toolchain in a single PR" from #1259. From cilium/cilium@2f7e2f3: According to [1] as of Go 1.21 we either need to specify the full toolchain version in the `go` directive or add a `toolchain` directive with the concrete toolchain version. Opt for the former and make sure it's kept up to date by renovate bot. [1] golang/go#62278 (comment) Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
added a commit
that referenced
this pull request
Oct 11, 2023
PR #1536 broke "renovate update Go toolchain in a single PR" from #1259 because in the actual state it could only bump the go directive from minor versions, not bumping the patch needed by the workflows github actions reading that version. From cilium/cilium@2f7e2f3: According to [1] as of Go 1.21 we either need to specify the full toolchain version in the `go` directive or add a `toolchain` directive with the concrete toolchain version. Opt for the former and make sure it's kept up to date by renovate bot. [1] golang/go#62278 (comment) Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
added a commit
that referenced
this pull request
Oct 11, 2023
PR #1536 broke "renovate update Go toolchain in a single PR" from #1259 because in the actual state it could only bump the go directive from minor versions, not bumping the patch needed by the workflows github actions reading that version. From cilium/cilium@2f7e2f3: According to [1] as of Go 1.21 we either need to specify the full toolchain version in the `go` directive or add a `toolchain` directive with the concrete toolchain version. Opt for the former and make sure it's kept up to date by renovate bot. [1] golang/go#62278 (comment) Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1169.
It was way more complicated than initially thought and it took me something like 2 days asynchronously to debug/test on the fork. The result should be as fancy as this PR on the fork https://github.com/mtardy/tetragon/pull/63/files.