Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow example to run as script #251

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Allow example to run as script #251

merged 1 commit into from
Sep 8, 2023

Conversation

azzid
Copy link
Contributor

@azzid azzid commented Sep 8, 2023

Doing apply, logs, delete in sequence as fast as a script does has the unfortuante effect that it does logs before the pod is ready.

Adding a wait sorts that.

Sending ctrl+c to break logs will however terminate bash before delete can run.

Putting delete in a trap sorts that.

Doing apply, logs, delete in sequence as fast as a script does
has the unfortuante effect that it does logs before the pod is
ready.

Adding a wait sorts that.

Sending ctrl+c to break logs will however terminate bash before
delete can run.

Putting delete in a trap sorts that.
azzid referenced this pull request Sep 8, 2023
Signed-off-by: Martynas Pumputis <m@lambda.lt>
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brb brb merged commit 03e1711 into cilium:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants