Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to the grafana.json file #2

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Fix link to the grafana.json file #2

merged 1 commit into from
Nov 19, 2019

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Nov 19, 2019

Closes #1

@gandro
Copy link
Member

gandro commented Nov 19, 2019

Thanks for your contribution! Could you please sign-off your commit as per the Cilium Contributor Guide?

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 19, 2019

@gandro Hi. Err... It's not really clear to me where I should add that line? In the commit message?

@gandro
Copy link
Member

gandro commented Nov 19, 2019 •
edited
Loading

@gandro Hi. Err... It's not really clear to me where I should add that line? In the commit message?

Yes. The preferred way is to use git commit --signoff - git will add it to your commit message automatically.

@Skarlso
Fix link to the grafana.json file
37c45ea 
Closes cilium#1

Signed-off-by: Gergely Brautigam <skarlso777@gmail.com>
@tgraf tgraf merged commit 3da5a5e into cilium:master Nov 19, 2019
@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 19, 2019

@tgraf @gandro thank you! :)

@glibsm
Copy link
Member

glibsm commented Nov 19, 2019

Thank you and congrats on PR #1 ! 🎉

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 19, 2019

Thank you! :) :)

rolinh added a commit that referenced this pull request Feb 10, 2025
@rolinh
migrate Renovate config take #2
8f25df8 
Commit 5ef17d1 missed a conversion from
`matchFiles` to `matchFileNames`.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Suggested-by: Signed-off-by: Alexandre Perrin <alex@isovalent.com>
rolinh added a commit that referenced this pull request Feb 10, 2025
@rolinh
migrate Renovate config take #2
e939997 
Commit 5ef17d1 missed a conversion from
`matchFiles` to `matchFileNames`.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Suggested-by: Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgraf tgraf tgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page note found on deploy-hubble-and-grafana/grafana.json
4 participants
@Skarlso @gandro @glibsm @tgraf