Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --cel-expression filter in hubble observe #1465

Closed
wants to merge 1 commit into from

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Apr 22, 2024

This also updates cilium since the CEL filter expression is only available in main currently.

@chancez chancez added the 🌟 kind/feature This introduces new functionality. label Apr 22, 2024
@chancez chancez added this to the Hubble CLI 1.0 milestone Apr 22, 2024
@chancez chancez self-assigned this Apr 22, 2024
@chancez chancez requested review from a team as code owners April 22, 2024 21:59
@chancez chancez requested review from marseel and removed request for a team April 22, 2024 21:59
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Apr 22, 2024
@chancez chancez requested a review from kaworu April 22, 2024 21:59
@chancez chancez linked an issue Apr 22, 2024 that may be closed by this pull request
Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
@chancez chancez force-pushed the pr/chancez/hubble_cel_filter branch from 445ffa4 to 257038a Compare April 22, 2024 23:49
Copy link

@marseel marseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I would strongly encourage to try to get rid of cilium/cilium dependency until it's not too late :)
Most of the imports seem to care only about github.com/cilium/cilium/api / github.com/cilium/cilium/pkg/monitor/api / github.com/cilium/cilium/pkg/hubble/api/v1 and few other "random" imports.

@glibsm
Copy link
Member

glibsm commented Apr 23, 2024

lgtm, but I would strongly encourage to try to get rid of cilium/cilium dependency until it's not too late :) Most of the imports seem to care only about github.com/cilium/cilium/api / github.com/cilium/cilium/pkg/monitor/api / github.com/cilium/cilium/pkg/hubble/api/v1 and few other "random" imports.

We've been asking for a module in api/ for years. There is no way to import api without importing cilium if they share the same module.

Also, the hubble codebase is about to merge into cilium/cilium anyway, so it's somewhat of a moot point now.

@chancez
Copy link
Contributor Author

chancez commented Apr 23, 2024

Yeah, I'm going to create a PR to cilium/cilium now that cilium/cilium#31893 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-release-note-label PR is blocked until the release note is set 🌟 kind/feature This introduces new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CEL support to Hubble CLI
3 participants