info: expose ksym info and func info by ProgramInfo #1576
Conversation
03e5d62 to
8a66787
Compare
|
(By the way, a common format for referring to a commit in Linux is |
8a66787 to
813cc7a
Compare
This commit renames btf.FuncInfos to btf.FuncOffsets and makes its contents (now a btf.FuncOffset) accessible to external packages. As a result, LoadFuncInfos now returns FuncOffsets instead of FuncInfos. LoadFuncInfos has always been for internal use only, since the contents of btf.FuncInfos were not externally accessible. A follow-up commit will add a ProgramInfo method that returns a btf.FuncOffsets, making this more widely accessible. Signed-off-by: Timo Beckers <timo@isovalent.com>
This removes the use of package unsafe in info.go. A follow-up commit will use NewSlicePointer in a similar way. Signed-off-by: Timo Beckers <timo@isovalent.com>
Exposes additional metadata fields from `bpf_prog_info` to `ProgramInfo`: - nr_jited_ksyms - jited_ksyms Meanwhile, expose ksym addresses from ProgramInfo. `bpf_prog_info` supports ksym info since commit torvalds/linux@dbecd7388476 ("bpf: get kernel symbol addresses via syscall"). Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
`bpf_prog_info` supports func info since commit torvalds/linux@838e96904ff3 ("bpf: Introduce bpf_func_info"). Signed-off-by: Leon Hwang <hffilwlqm@gmail.com> Co-authored-by: Timo Beckers <timo@isovalent.com>
813cc7a to
deb3885
Compare
|
@Asphaltt I ended up making a few changes after I noticed we already had most of the code for parsing funcinfos in @dylandreimerink Please have a look. LoadFuncInfos was always mostly for internal use. It could be called, but the resulting object wasn't useful for external callers. There's now a new type called FuncOffset(s) that pairs a raw insn offset with a btf.Func to denote its position. Previously this info was only embedded through ProgramInfo.Instructions(), but this is way too expensive (and complicated) if the caller only cares about subprog signatures and bytecode layout. |
In pwru, I'm planning to improve the tracing info of bpf prog by mapping ksym addresses to bpf prog info, i.e. the function name of subprograms.
Therefore, it requires more prog info exposed from ProgramInfo, including ksym info and func info.
bpf_prog_infosupports ksym info since commit torvalds/linux@dbecd7388476 ("bpf: get kernel symbol addresses via syscall"), and supports func info since commit torvalds/linux@838e96904ff3 ("bpf: Introduce bpf_func_info").