Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go,testdata: drop support for Go 1.21, pin testdata toolchain to 1.23 #1563

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

ti-mo
Copy link
Collaborator

@ti-mo ti-mo commented Sep 12, 2024

make in the repo root started complaining with the recent Go 1.23 release:

go: golang.org/x/tools/cmd/stringer@latest: golang.org/x/tools@v0.25.0 requires go >= 1.22.0 (running go 1.21.1; GOTOOLCHAIN=local)

Bump the Go version in the container to 1.23 and pin it so we can easily identify which version the container was built with.

@ti-mo ti-mo requested a review from a team as a code owner September 12, 2024 09:14
`make` in the repo root started complaining with the recent Go 1.23 release:

> go: golang.org/x/tools/cmd/stringer@latest: golang.org/x/tools@v0.25.0 requires go >= 1.22.0 (running go 1.21.1; GOTOOLCHAIN=local)

Bump the Go version in the container to 1.23 and pin it so we can easily
identify which version the container was built with.

Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo merged commit 08e7424 into cilium:main Sep 12, 2024
17 checks passed
@ti-mo ti-mo deleted the tb/go-1.22 branch September 12, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant