Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh: hopefully fix apidiff workflow #1401

Merged
merged 1 commit into from
Mar 27, 2024
Merged

gh: hopefully fix apidiff workflow #1401

merged 1 commit into from
Mar 27, 2024

Conversation

lmb
Copy link
Collaborator

@lmb lmb commented Mar 27, 2024

actions/github-script v5 changed how API is exposed to the scripts. Seems like we need to add .rest here and there.

@lmb
gh: hopefully fix apidiff workflow
62f8f59 
actions/github-script v5 changed how API is exposed to the scripts.
Seems like we need to add `.rest` here and there.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb
Copy link
Collaborator Author

lmb commented Mar 27, 2024

See https://github.com/cilium/ebpf/actions/runs/8453171623/job/23155266165#step:4:48

TypeError: Cannot read properties of undefined (reading 'addLabels')
    at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35424:16), <anonymous>:11:23)
    at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35425:12)
    at main (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35522:26)
    at /home/runner/work/_actions/actions/github-script/v7/dist/index.js:35497:1
    at /home/runner/work/_actions/actions/github-script/v7/dist/index.js:35553:3
    at Object.<anonymous> (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35556:12)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
Error: Unhandled error: TypeError: Cannot read properties of undefined (reading 'addLabels')

@lmb lmb marked this pull request as ready for review March 27, 2024 15:45
@lmb lmb requested a review from a team as a code owner March 27, 2024 15:45
@lmb lmb merged commit 32e7497 into cilium:main Mar 27, 2024
15 checks passed
@lmb lmb deleted the fix-trusted-workflow branch March 27, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lmb